Add alias pygame.Sound
#3063
Merged
Add alias pygame.Sound
#3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good to hold off on examples and usage changes for now, since the docs go up to the website before the next release. And people sometimes open issues when examples fail to run on the latest release version (as they should). |
I didn't think about that! reverted :) (this will probably have to be squashed for merging because reverting took me 4 commits for no reason) |
bilhox
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been enough time for the Sound class to get its alias!
I don't recall the last time I used a Channel object but somehow that has the alias and not Sound, which is more common.
I also slightly changed the examples to use the alias, if you prefer how it was previously just say so and I'll revert at the speed of light.